util, assert: improve array comparison performance#22111
Closed
BridgeAR wants to merge 5 commits intonodejs:masterfrom
Closed
util, assert: improve array comparison performance#22111BridgeAR wants to merge 5 commits intonodejs:masterfrom
BridgeAR wants to merge 5 commits intonodejs:masterfrom
Conversation
This reduces the runtime and makes sure the strict and loose options can be tested individually. Besides that a couple of redundant cases were removed.
This adds a smarter logic to compare object keys and it also skips the object key comparison for arrays, if possible. Besides that it adds a fast path for empty objects and arrays. It also adds a fast path for boxed strings and improves the comparison performance for TypedArrays with extra keys on the object. On top of that a few functions are now safer to call by using uncurryThis and by caching the actual function.
Currently the comparison could throw an error in case a boxed primitive has no valueOf function on one side of the assert call.
nodejs-github-bot
added
the
util
BridgeAR
added
the
performance
Member
Author
BridgeAR
added
assert
Member
|
Member
Author
|
@jasnell I fixed the test already. |
Member
Author
|
@nodejs/util @nodejs/testing PTAL |
Member
Author
Member
|
@nodejs/benchmarking |
Member
Author
|
Since this PR did not yet get any attention and I have a follow-up PR. I am closing this one and just have a combined PR afterwards. See #22197 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for detailed description.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes